Fix reconnect_attempts not working with Redis 4.8
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our apps are currently using Redis 4.8 due to a constraint from the version of Sidekiq we are using. However in a previous commit, we used Redis 5 syntax to specify a new value for `reconnect_attempts`. This is not compatible with Redis 4.8. Therefore updating the syntax to match that expected for Redis 4.8 [1] and explicitly stating the version of Redis we expect (since Redis 5 doesn't support the legacy syntax). 1: https://github.com/redis/redis-rb/tree/v4.8.1?tab=readme-ov-file#reconnections
brucebolt
added a commit
that referenced
this pull request
Sep 10, 2024
This reverts the change made in #108.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our apps are currently using Redis 4.8 due to a constraint from the version of Sidekiq we are using.
However in a previous commit, we used Redis 5 syntax to specify a new value for
reconnect_attempts. This is not compatible with Redis 4.8.Therefore updating the syntax to match that expected for Redis 4.8 and explicitly stating the version of Redis we expect (since Redis 5 doesn't support the legacy syntax).
Trello card