diff --git a/app/views/govuk_publishing_components/components/_phase_banner.html.erb b/app/views/govuk_publishing_components/components/_phase_banner.html.erb index d3fc0796a5..e347a2a186 100644 --- a/app/views/govuk_publishing_components/components/_phase_banner.html.erb +++ b/app/views/govuk_publishing_components/components/_phase_banner.html.erb @@ -5,7 +5,7 @@ app_name ||= nil phase ||= nil message ||= nil inverse ||= false -ga4_tracking ||= false +disable_ga4 ||= false unless message.present? if phase == "beta" @@ -20,7 +20,7 @@ container_css_classes << "gem-c-phase-banner--inverse" if inverse data_attributes = {} -if ga4_tracking +unless disable_ga4 data_attributes[:ga4_phase_banner] = phase data_attributes[:module] = "ga4-link-tracker" data_attributes[:ga4_track_links_only] = "" diff --git a/app/views/govuk_publishing_components/components/docs/phase_banner.yml b/app/views/govuk_publishing_components/components/docs/phase_banner.yml index 856fb75941..d67c5f433d 100644 --- a/app/views/govuk_publishing_components/components/docs/phase_banner.yml +++ b/app/views/govuk_publishing_components/components/docs/phase_banner.yml @@ -32,11 +32,11 @@ examples: app_name: Skittles Maker phase: beta inverse: true - with_ga4_tracking: + without_ga4_tracking: description: | - Enables GA4 tracking on the banner. This includes link tracking on the component itself, and allows pageviews to record the presence of the banner on page load. + Disables GA4 tracking on the banner. Tracking is enabled by default. This includes link tracking on the component itself, and allows pageviews to record the presence of the banner on page load. data: app_name: Skittles Maker phase: beta inverse: true - ga4_tracking: true + disable_ga4: true diff --git a/spec/components/phase_banner_spec.rb b/spec/components/phase_banner_spec.rb index f55ff62c54..a2c764f5b8 100644 --- a/spec/components/phase_banner_spec.rb +++ b/spec/components/phase_banner_spec.rb @@ -42,7 +42,7 @@ def component_name end it "renders banner with ga4 attributes" do - render_component(phase: "beta", ga4_tracking: true) + render_component(phase: "beta") assert_select ".gem-c-phase-banner[data-ga4-phase-banner=beta]" assert_select ".gem-c-phase-banner[data-module=ga4-link-tracker]" assert_select ".gem-c-phase-banner[data-ga4-track-links-only]" @@ -51,7 +51,7 @@ def component_name end it "renders banner without ga4 attributes" do - render_component(phase: "beta", ga4_tracking: false) + render_component(phase: "beta", disable_ga4: true) assert_select ".gem-c-phase-banner[data-ga4-phase-banner]", false assert_select ".gem-c-phase-banner[data-module=ga4-link-tracker]", false assert_select ".gem-c-phase-banner[data-ga4-track-links-only]", false