Use GOV.UK elements v3.0.1 #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog for GOV.UK elements: https://github.com/alphagov/govuk_elements/blob/master/CHANGELOG.md Changelog for the GOV.UK frontend toolkit: https://github.com/alphagov/govuk_frontend_toolkit/blob/master/CHANGELOG .md
This is no longer required with the radios and checkboxes released in govuk-elements-sass v3.0.0.
To use the new markup released in GOV.UK elements 3.0.0.
Update examples of radio buttons and checkboxes. Replace ‘.block-label` with `.multiple-choice` as the block-label class no longer exists.
Increase the spacing between the radio button and checkbox examples.
This had nested form elements, which was a mistake. Removing these.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the examples for radio buttons and checkboxes to match those used by GOV.UK elements.
It includes breaking changes - as the markup for custom radio buttons and checkboxes has changed.
In summary:
block-labelwithmultiple-choicein commentsScreenshots:
Note: There are also breaking changes to the classnames used for errors and validation, but the prototype kit does not have examples of these.