Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump gulp-sass to increase node-sass dependency #352

Merged
merged 2 commits into from
Feb 6, 2017

Conversation

feedmypixel
Copy link
Contributor

@feedmypixel feedmypixel commented Jan 27, 2017

Npm install AWS Elastic Beanstalk fails

Currently when deploying the Gov UK prototype kit to AWS using their Linux node AMI with nodeJs 6.9.1 the node-sass dependency of gulp-sass v2.3.2 is incompatible with nodeJs 6 and Linux node-sass/releases/tag/v3.4.2

To enable this to work we need to bump gulp-sass to v3.0.0 that has node-sass v4.0.0 which is supported on Linux with nodeJs 6

@feedmypixel
Copy link
Contributor Author

feedmypixel commented Jan 27, 2017

Of note gulp-sass >=3.0.0 would work

@joelanman
Copy link
Contributor

thanks - any reason not to just go to latest? 3.1.0

@feedmypixel
Copy link
Contributor Author

If gulp-sass 3.1.0 works for you it works for me. Ta.

@gemmaleigh
Copy link
Contributor

Hi @feedmypixel, I've updated this to 3.1.0. Cheers!

@gemmaleigh gemmaleigh merged commit 08368b7 into alphagov:master Feb 6, 2017
@feedmypixel
Copy link
Contributor Author

Hi @feedmypixel, I've updated this to 3.1.0. Cheers!

@gemmaleigh lovely ta

@joelanman joelanman mentioned this pull request Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants