Mixing of semi-colon styles can cause errors

[tombye]

The Show/Hide content module was written with the standardJS style of semicolon use. All our other GOVUK modules use the JSLint style and combining the two can cause errors.

For example, if you have the Show/Hide content module followed by the Stick-at-top-when-scrolling module, you get this:

End of Show/Hide content module:

  GOVUK.ShowHideContent = ShowHideContent
  global.GOVUK = GOVUK
})(window)

Start of Stick-at-top-when-scrolling module:

(function (global) {
  "use strict";

...which causes this error:

Uncaught TypeError: (intermediate value)(intermediate value)(intermediate value)(...) is not a function

I think the parser is seeing only line breaks between })(window) and (function (global) { so assumes you mean:

(function () { ... })(window)(function (global) { ... })

(function () { ... })(window) doesn't return a function so it breaks.

We've solved this on Digital Marketplace by adding a semicolon after the Show/Hide content module block but having a project-specific fix for this isn't ideal.

[robinwhittleton]

#334 (that @tvararu referenced) lints every JS file with Standard. This fixes this issue. Looking at the original example, both show-hide-content
and stick-at-top-when-scrolling start with the same ;(function (global) {.