From cacbf2537adb8e61cbfdc2bd4561561a32972e31 Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Wed, 21 Feb 2018 16:08:24 +0000 Subject: [PATCH 1/2] Remove redundant Google Analytics This already is covered by Google Tag Manager --- docs/views/includes/analytics.html | 9 --------- docs/views/includes/head.html | 4 ---- server.js | 2 -- 3 files changed, 15 deletions(-) delete mode 100644 docs/views/includes/analytics.html diff --git a/docs/views/includes/analytics.html b/docs/views/includes/analytics.html deleted file mode 100644 index 20402668d0..0000000000 --- a/docs/views/includes/analytics.html +++ /dev/null @@ -1,9 +0,0 @@ - \ No newline at end of file diff --git a/docs/views/includes/head.html b/docs/views/includes/head.html index 6bf1825f3d..f78e30e92f 100644 --- a/docs/views/includes/head.html +++ b/docs/views/includes/head.html @@ -4,7 +4,3 @@ - -{% if promoMode == 'true' and analyticsId %} - {% include "includes/analytics.html" %} -{% endif %} diff --git a/server.js b/server.js index fe95c5da12..832f7099a8 100644 --- a/server.js +++ b/server.js @@ -31,7 +31,6 @@ var useAuth = process.env.USE_AUTH || config.useAuth var useAutoStoreData = process.env.USE_AUTO_STORE_DATA || config.useAutoStoreData var useHttps = process.env.USE_HTTPS || config.useHttps var useBrowserSync = config.useBrowserSync -var analyticsId = process.env.ANALYTICS_TRACKING_ID var gtmId = process.env.GOOGLE_TAG_MANAGER_TRACKING_ID env = env.toLowerCase() @@ -110,7 +109,6 @@ app.use(bodyParser.urlencoded({ })) // Add variables that are available in all views -app.locals.analyticsId = analyticsId app.locals.gtmId = gtmId app.locals.asset_path = '/public/' app.locals.useAutoStoreData = (useAutoStoreData === 'true') From ab938723b7445d1b8cb5b30eedf0e1de9c1a0b61 Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Thu, 22 Feb 2018 12:00:48 +0000 Subject: [PATCH 2/2] Update CHANGELOG with unreleased changes --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a2b860c88f..5e2a83e2af 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +# Unreleased + +Bug fixes: + +- [#491 Remove redundant Google Analytics](https://github.com/alphagov/govuk_prototype_kit/pull/491) + # 6.3.0 New features: