Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update step by step navigation to use new focus states #755

Closed
hannalaakso opened this issue May 24, 2019 · 4 comments
Closed

Update step by step navigation to use new focus states #755

hannalaakso opened this issue May 24, 2019 · 4 comments
Assignees
@NickColley @DebsDee
Labels
🕔 Hours A well understood issue which we expect to take less than a day to resolve.

Comments

@hannalaakso
Copy link
Member

With the work done in alphagov/govuk-design-system#677 and the upcoming release of GOV.UK Frontend that updates the focus states to be WCAG 2.1 compliant, we should update the Step by step navigation to use the new focus states.
@kellylee-gds kellylee-gds mentioned this issue May 24, 2019
Closed
34 tasks
@kellylee-gds kellylee-gds added 🕔 Hours A well understood issue which we expect to take less than a day to resolve. Priority: low and removed awaiting-triage labels May 29, 2019
@36degrees 36degrees added this to the v9.0.0 milestone Jul 9, 2019
@hannalaakso hannalaakso self-assigned this Jul 22, 2019
@hannalaakso
Copy link
Member Author

We need to get the GOV.UK Publishing to look at how the pattern should be updated.

@hannalaakso hannalaakso removed their assignment Jul 22, 2019
@NickColley
Copy link
Contributor

It's also worth noting that, user agent focus styles pass WCAG 2.1 requirements by technicality.

@NickColley NickColley removed this from the v9.0.0 milestone Jul 22, 2019
@NickColley
Copy link
Contributor

This is now unblocked since GOV.UK Publishing have updated this pattern to use the new focus styles:

Screen Shot 2019-08-27 at 16 01 34

Screen Shot 2019-08-27 at 16 01 38

https://components.publishing.service.gov.uk/component-guide/step_by_step_nav/preview

We should take care not to re-introduce this bug: alphagov/govuk_publishing_components#1058

@NickColley
Copy link
Contributor

I spoke to @DebsDee and we think this would be good one to pair on.

@DebsDee DebsDee mentioned this issue Aug 28, 2019
Merged
@DebsDee DebsDee closed this as completed Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickColley NickColley

@DebsDee DebsDee

Labels
🕔 Hours A well understood issue which we expect to take less than a day to resolve.
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@36degrees @NickColley @hannalaakso @DebsDee @kellylee-gds