Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nunjucks templates from GOV.UK Frontend plugin used internally #2352

Closed
colinrotherham opened this issue Oct 3, 2023 · 2 comments · Fixed by #2355
Closed

Nunjucks templates from GOV.UK Frontend plugin used internally #2352

colinrotherham opened this issue Oct 3, 2023 · 2 comments · Fixed by #2355
Assignees
@colinrotherham
Labels
🐛 Bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@colinrotherham
Copy link
Contributor

Description of the issue

Manage prototype pages use GOV.UK Frontend "internal" styles, scripts, images, fonts etc

But they're rendered using GOV.UK Frontend "plugin" Nunjucks views and macros

Steps to reproduce the issue

  1. Create a new prototype which uses govuk-frontend@4.7.0 by default
  2. Downgrade "plugin" GOV.UK Frontend using npm install govuk-frontend@4.2.0
  3. Start the prototype with USE_HTTPS=false PASSWORD=test to see the password page
  4. Click "Continue" to see the Error summary component
  5. Notice that fixed accessibility bugs have returned

Actual vs expected behaviour

Actual: Nunjucks templates from "plugin" GOV.UK Frontend are used
Expected: Nunjucks templates from "internal" GOV.UK Frontend are used
@colinrotherham colinrotherham added the 🐛 Bug Something isn't working the way it should (including incorrect wording in documentation) label Oct 3, 2023
@colinrotherham colinrotherham changed the title Nunjucks templates from GOV.UK Frontend plugin used by internal pages Nunjucks templates from GOV.UK Frontend plugin used internally Oct 3, 2023
@colinrotherham
Copy link
Contributor Author

This was flagged whilst testing GOV.UK Frontend v5

Noticeably the class .js-enabled was missing its new .govuk-frontend-supported counterpart

@colinrotherham colinrotherham self-assigned this Oct 3, 2023
This was referenced Oct 3, 2023
Closed
Merged
@colinrotherham
Copy link
Contributor Author

Currently in review: #2355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colinrotherham colinrotherham

Labels
🐛 Bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent management pages using "plugin" GOV.UK Frontend views alphagov/govuk-prototype-kit
1 participant
@colinrotherham