Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using govuk mustache template module #198

Closed
joelanman opened this issue May 20, 2016 · 1 comment · Fixed by #212
Closed

Stop using govuk mustache template module #198

joelanman opened this issue May 20, 2016 · 1 comment · Fixed by #212

Comments

@joelanman
Copy link
Contributor

We pull in both the Jinja and mustache template, and use the assets from mustache. We could just use the assets from Jinja. Is there any downside, taking into account Jinja is a repo, not an npm module

@gemmaleigh
Copy link
Contributor

gemmaleigh commented May 20, 2016

At the moment, we're using the packaged release of the Jinja version of the govuk_template.

It would mean we wouldn't be able to use npm outdated to find out when there is a new version of the govuk_template, but we're likely to know when it is updated.

Ideally, a new repo would be set up for the Jinja version the govuk_template.

What about:

  • raise an issue with the template to publish the Jinja version to npm (cc. @dsingleton, @alexmuller).
  • remove the grunt tasks which copy assets from the Mustache version of the template and instead copy the assets from the Jinja version
  • when the Jinja version of the template is published as an npm module, update package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants