From fd497c6d3ac2031d854e3d7ee6a7d08586e6a902 Mon Sep 17 00:00:00 2001 From: Andy Mantell <134642+andymantell@users.noreply.github.com> Date: Wed, 25 Nov 2020 10:43:25 +0000 Subject: [PATCH 1/2] Invert notification banner header / content colouring to fix gap on large screens --- .../components/notification-banner/_index.scss | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/govuk/components/notification-banner/_index.scss b/src/govuk/components/notification-banner/_index.scss index 1990f56f91..d6d021fb7b 100644 --- a/src/govuk/components/notification-banner/_index.scss +++ b/src/govuk/components/notification-banner/_index.scss @@ -5,6 +5,8 @@ border: $govuk-border-width solid $govuk-brand-colour; + background-color: $govuk-brand-colour; + &:focus { outline: $govuk-focus-width solid $govuk-focus-colour; } @@ -16,8 +18,6 @@ // Ensures the notification header appears separate to the notification body text in high contrast mode border-bottom: 1px solid transparent; - background-color: $govuk-brand-colour; - @include govuk-media-query($from: tablet) { padding: 2px govuk-spacing(4) govuk-spacing(1); } @@ -34,10 +34,16 @@ } .govuk-notification-banner__content { - margin: govuk-spacing(3); + padding: govuk-spacing(3); + + background-color: $govuk-body-background-colour; @include govuk-media-query($from: tablet) { - margin: govuk-spacing(4); + padding: govuk-spacing(4); + } + + > :last-child { + margin-bottom: 0; } } @@ -57,9 +63,7 @@ .govuk-notification-banner--success { border-color: $govuk-success-colour; - .govuk-notification-banner__header { - background-color: $govuk-success-colour; - } + background-color: $govuk-success-colour; .govuk-notification-banner__link { @include govuk-link-style-success; From 06c155ab71c7b1fafda9f32dd491c780e19f42be Mon Sep 17 00:00:00 2001 From: Andy Mantell <134642+andymantell@users.noreply.github.com> Date: Wed, 25 Nov 2020 12:07:40 +0000 Subject: [PATCH 2/2] Changelog entry for notification banner fix on high res screens (fd497c6d3ac2031d854e3d7ee6a7d08586e6a902) --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index bb9f2e08d3..e976092095 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,12 @@ ## Unreleased +### Fixes + +We’ve made fixes to GOV.UK Frontend in the following pull requests: + +- [#2035: Fix hairline gap between notification banner header and outer border on high resolution screens in Chrome/Edge (Blink)](https://github.com/alphagov/govuk-frontend/pull/2035) + ## 3.10.0 (Feature release) ### New features