Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent initialise logic for modules #666

Closed
NickColley opened this issue Apr 19, 2018 · 0 comments
Closed

Use consistent initialise logic for modules #666

NickColley opened this issue Apr 19, 2018 · 0 comments

Comments

@NickColley
Copy link
Contributor

For some components we are initialising all instances of modules, which means if someone wants control over what is initialised they can't do it.

In #616 we split this logic out https://github.com/alphagov/govuk-frontend/pull/616/files#diff-9b2996c4ee664e732889da8297feafd3R12 but there is an inconsistency.

We could consider repeating this pattern for the other components, or consider a wrapper function such as https://github.com/alphagov/govuk_frontend_toolkit/tree/master/javascripts/govuk.

This alongside #660 would make it easy for people to have control over when they want components to initialise, useful if you need to wait for the document to be ready for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant