Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Rename captionSize -> captionClass for consistency #632

Closed
NickColley opened this issue Apr 5, 2018 · 2 comments
Closed

Table: Rename captionSize -> captionClass for consistency #632

NickColley opened this issue Apr 5, 2018 · 2 comments

Comments

@NickColley
Copy link
Contributor

It'd be good to change captionSize to captionClass to better describe what it's doing, this is consistent with other places we put a class on a part of a component.

http://localhost:3000/components/table
@36degrees
Copy link
Contributor

Recorded here.

@kr8n3r
Copy link

kr8n3r commented Apr 12, 2018

done in #643

@kr8n3r kr8n3r closed this as completed Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@36degrees @NickColley @kr8n3r