Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export GOVUKFrontendComponent publicly as Component #5327

Open
1 task
Tracked by #5292
romaricpascal opened this issue Sep 16, 2024 · 1 comment
Open
1 task
Tracked by #5292

Export GOVUKFrontendComponent publicly as Component #5327

romaricpascal opened this issue Sep 16, 2024 · 1 comment

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Sep 16, 2024 •
edited
Loading

What

Export GOVUKFrontendComponent publicly, renaming it as Component.

Why

This will let services and other design systems use the class for their own components, providing them with the checks for support and root element

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • GOVUKFrontendComponent is publicly exported as Component
@romaricpascal romaricpascal mentioned this issue Sep 16, 2024
Open
@romaricpascal
Copy link
Member Author

question Would it be worth adding a typescript-integration project as part of this work to check that people using TypeScript to check their JSDoc can extend the component as intended?

@romaricpascal romaricpascal mentioned this issue Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romaricpascal