Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ElementError to use component's moduleName instead of componentName #5324

Open
2 tasks
Tracked by #5292
romaricpascal opened this issue Sep 16, 2024 · 0 comments
Open
2 tasks
Tracked by #5292
Assignees

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Sep 16, 2024

What

Refactor ElementError to use component's moduleName instead of componentName. This should be supported by a formatErrorMessage(Component, message) helper to format the message as <MODULE_NAME>: <MESSAGE> consistently.

Why

This will enable the ElementError to be thrown from the base component class rather than in each of the individual components.

The formatting helper function will allow components to follow the same format with other errors they would throw.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • A helper for formatting the error messages for a given component has been added
  • ElementError uses the new helper to format its message
@romaricpascal romaricpascal changed the title Refactor ElementError to receive moduleName instead of componentName Refactor ElementError to use component's moduleName instead of componentName Sep 16, 2024
@patrickpatrickpatrick patrickpatrickpatrick self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress 📝
Development

No branches or pull requests

2 participants