Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate possible race condition in puppeteer helpers' request handling #5221

Open
2 tasks
romaricpascal opened this issue Aug 9, 2024 · 0 comments
Open
2 tasks

Comments

@romaricpascal
Copy link
Member

What

We've been getting a couple of 'Request is already handled!' errors during our tests. Those are intermitent and seem to happen from this custom request handler not checking that the request has already been handled before trying to answer itself.

Would be good to understand if we need to add a check that the request has already been handled before doing anything, or if something else is afoot.

Why

Make our tests more robust and reduce uncertainty

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Cause for the 'Request is already handled!' errors has been identified
  • Fix for the error has been implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant