Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for viewing of inverse modifications of components in the review app #3780

Closed
owenatgov opened this issue Jun 9, 2023 · 0 comments · Fixed by #3808
Closed

Allow for viewing of inverse modifications of components in the review app #3780

owenatgov opened this issue Jun 9, 2023 · 0 comments · Fixed by #3808
Assignees
@querkmachine
Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve.

Comments

@owenatgov
Copy link
Contributor

What

Add functionality to the review app to apply a dark background on examples that are intended to show inverse modifiers of components.

This can probably done quite easily by updating the showExamples macro to check for a param like inverse in the component example list.

Why

So that we can more easily view and manually test these components and their modifiers.

Originally raised in #3774

Who needs to work on this

Developers
@owenatgov owenatgov added the 🕔 hours A well understood issue which we expect to take less than a day to resolve. label Jun 9, 2023
@owenatgov owenatgov mentioned this issue Jun 9, 2023
Merged
This was referenced Jun 9, 2023
Closed
Merged
@querkmachine querkmachine self-assigned this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@querkmachine querkmachine

Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to invert background colour in review app examples alphagov/govuk-frontend
2 participants
@querkmachine @owenatgov