Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary-list component contains axe accessibility issue #2150

Closed
alittlecross opened this issue Feb 16, 2021 · 3 comments
Closed

summary-list component contains axe accessibility issue #2150

alittlecross opened this issue Feb 16, 2021 · 3 comments
Labels
awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@alittlecross
Copy link

Description of the issue

Using the summary-list component with multiple rows where some do not have actions; the component adds a span to those rows. This is considered a serious issue by the Axe accessibility tool, presenting the below error when using the axe-core chrome extension:

<dl> elements must only directly contain properly-ordered <dt> and <dd> groups, <script>, <template> or <div> elements

The section of the template relating to this is here.

The issue may be resolvable by using a div instead so long as the govuk-summary-list__actions class results in the elements rendering the same.

Steps to reproduce the issue

Use the summary-list component with multiple rows where some do not have actions. Using the axe-core chrome extension on the page that contains that component:

Screenshot 2021-02-16 at 10 49 57

Actual vs expected behaviour

No accessibility issue.

Environment (where applicable)

I am using the below however the component remains the same in the current version of the toolkit and colleagues have witnessed the same behaviour on macOS Mojave, with other versions of Chrome.

  • Operating system: macOS Catalina
  • Browser: Chrome
  • Browser version: 88.0.4324.150
  • GOV.UK Frontend Version: 3.10.1
@alittlecross alittlecross added awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) labels Feb 16, 2021
@36degrees
Copy link
Contributor

Hi @alittlecross – thanks for flagging this.

I think this is the same as issue #1806 – would you mind checking?

@alittlecross
Copy link
Author

Yep - Malcolm is in fact on my team, but raised that before I joined - then I didn't thoroughly search the issues to check it hadn't been raised before - apologies.

@36degrees
Copy link
Contributor

No worries – thanks again for flagging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Development

No branches or pull requests

2 participants