You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
it’s recommended we remove aria-labelledby from the markup for the red and the green banners as they’re not landmarks (https://www.w3.org/TR/wai-aria-1.1/#landmark_roles) and therefore the label will never be read out (the same actually applies to our current error summary)
we should explain the accessibility considerations – for example what the role= does – in comments in the code and/or tests.
I'm thinking that one thing we should highlight at the accessibility clinic is the approach of making the <p> tags look like headings when we have just a single line of content in the banner. We do this as we want to draw attention to the message in the banner and semantically you should haven't a heading tag that doesn't act as a heading for some content below it. However it'd be good to confirm that this isn't a concern as we're making an element look like another element.
What
Create the notification banner component in GOV.UK Frontend.
Why
Having reviewed the feedback from the working group, we now need to build the component in Frontend ready for release.
Depends on
Further detail
Some specific bits of feedback worth considering from the working group and accessibility clinic findings:
aria-labelledby
from the markup for the red and the green banners as they’re not landmarks (https://www.w3.org/TR/wai-aria-1.1/#landmark_roles) and therefore the label will never be read out (the same actually applies to our current error summary)role=
does – in comments in the code and/or tests.Done when…
The text was updated successfully, but these errors were encountered: