Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint HTML #1839

Closed
36degrees opened this issue Jun 17, 2020 · 1 comment
Closed

Lint HTML #1839

36degrees opened this issue Jun 17, 2020 · 1 comment

Comments

@36degrees
Copy link
Contributor

What

Lint the HTML outputted by our macros to ensure it's sensible and consistent.

Why

Further detail

As part of this, we might want to check for:

@36degrees
Copy link
Contributor Author

I'm closing this as we now have HTML linting in place (see src/govuk/components/components.template.test.js).

We still don't have a linting rule that covers the specific issue mentioned here (camel-casing SVG attributes). I'm unsure whether Angular is better at handling lowercase attributes now, but given we haven't seen this reoccur we should just keep an eye on it for now.

If it does come up again, we could consider writing our own rule for HTMLValidate that ensures SVG attributes are correctly cased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant