Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider a align-top modifier for Warning Text component #1352

Closed
dashouse opened this issue May 15, 2019 · 1 comment
Closed

Consider a align-top modifier for Warning Text component #1352

dashouse opened this issue May 15, 2019 · 1 comment
Labels
feature request User requests a new feature 🕔 hours A well understood issue which we expect to take less than a day to resolve.

Comments

@dashouse
Copy link

The Warning Text icon is always vertically centred within it's container. With a long warning message, the icon could appear unrelated to the text, for example appearing off screen on mobile.

We could add a modifier that changed the top value to ~20px to be used in this scenario.

Default:
Screen Shot 2019-05-15 at 12 11 06

Suggested modifier:
Screen Shot 2019-05-15 at 12 11 29
@kellylee-gds kellylee-gds added 🕔 hours A well understood issue which we expect to take less than a day to resolve. Priority: low feature request User requests a new feature and removed awaiting triage Needs triaging by team labels May 15, 2019
@NickColley NickColley mentioned this issue May 15, 2019
Open
@dashouse dashouse mentioned this issue Sep 19, 2019
Merged
@36degrees 36degrees mentioned this issue Oct 7, 2019
Closed
@NickColley NickColley mentioned this issue Oct 7, 2019
Merged
@NickColley
Copy link
Contributor

This has been changed by default.

@snyk-bot snyk-bot mentioned this issue Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request User requests a new feature 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NickColley @dashouse @kellylee-gds