Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document why the border on the character count input doesn't show as an error when the content is under the limit #2140

Closed
2 tasks done
christopherthomasdesign opened this issue Apr 13, 2022 · 1 comment · Fixed by #2188

Comments

@christopherthomasdesign
Copy link
Member

christopherthomasdesign commented Apr 13, 2022

What

Document why the border on the character count input doesn't show as an error state (i.e. thick red border) when there's been an error but content is under the limit.

For example:

Screenshot 2022-04-13 at 17 30 39

Why

A couple of users have raised issues about this – see alphagov/govuk-frontend#2588 and alphagov/govuk-frontend#1858

Who needs to work on this

Content designer, probs with accessibility specialist or frontend dev

Who needs to review this

Anyone

Done when

  • Rationale understood
  • Content written
@EoinShaughnessy
Copy link
Contributor

We've agreed wording in the PR.

However, we're holding off on publishing the change until we figure out how to release it alongside the bigger update to the same guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants