Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the access-limiting implementation #511

Open
chrisroos opened this issue Mar 7, 2018 · 0 comments
Open

Improve the access-limiting implementation #511

chrisroos opened this issue Mar 7, 2018 · 0 comments

Comments

@chrisroos
Copy link
Contributor

We currently use a single access_limited Array to determine whether an asset is access-limited, where:

  • An empty array means that it's not access limited.
  • An array containing 1 or more user UIDs means that the asset is only visible to the users represented by the UIDs in the array.

This is very similar to the way access-limiting works in the Content Store, with one difference being the lack of auth_bypass_ids in Asset Manager as mentioned in #471.

I think the current implementation is slightly confusing and think it might be better to model it using two fields: one to control whether the asset is access-limited and the other to contain the UIDs of authorised users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants