Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor position updates in downshift's combobox input #11

Closed
alostsock opened this issue Apr 19, 2023 · 3 comments
Closed

Fix cursor position updates in downshift's combobox input #11

alostsock opened this issue Apr 19, 2023 · 3 comments

Comments

@alostsock
Copy link
Owner

Making this as a note to myself. This only happens on mobile as far as I can tell -- there's probably some kind of race condition, or at least some conflict in state management happening.

Some hints of what is going on here:
downshift-js/downshift#1108 (comment)
and one of the mentioning issues:
twilio-labs/paste#2647

Haven't looked into it to see what the "proper" fix is yet.

@alostsock
Copy link
Owner Author

Seems to be fixed with 6c56965

@alostsock
Copy link
Owner Author

alostsock commented Apr 20, 2023

The previous commit fixed the issue, but doesn't populate the default values from cache anymore, so I've reverted it for now. Probably need to go with the solution in the linked downshift issue, to basically make the input fully controlled.

EDIT: Ah, nevermind. This was actually broken by #8

@alostsock alostsock reopened this Apr 20, 2023
@alostsock
Copy link
Owner Author

Should be fixed by 2a187e0, I think state wasn't being populated by mobx properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant