Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing an Add Player event shouldn't remove the player completely #259

Open
alopezlago opened this issue Oct 25, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@alopezlago
Copy link
Owner

  1. Create a game with a substitute player (i.e. non-starter)
  2. Add them to the game
  3. Remove them from the game through the event log

Expected:
The player is still there as a substitute
Actual:
The player is completely gone

This can also happen if someone leaves the game and then joins back in later, and you delete that join event.

@alopezlago alopezlago added the bug Something isn't working label Oct 25, 2023
@alopezlago
Copy link
Owner Author

This requires updating removeNewPlayer to not change the players collection. It also needs a cycle index so we don't remove events from before the addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant