This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Improvment on clustering performance #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 9, 2018 23:57
…ue as the edgeId as well.
…load instead of 1! =D That clone was is not needed once we just clone and check for the join condition.
mojoaxel
pushed a commit
to visjs/vis_original
that referenced
this pull request
Jun 9, 2019
* Improving the way _updateState deals with deleted edges * Realized can't simply use it as a Set to check existence. Set the value as the edgeId as well. * Removing the 1 line that was making my clustering take 10 seconds to load instead of 1! =D That clone was is not needed once we just clone and check for the join condition.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request, my network that was taking around 10s to load (due to clustering) and then more 3 seconds each time I was moving my nodes, now takes 1s to load and the moving is fluid again.
I basically used an object instead of an array that was causing a huge bottleneck on
_updateStatedue to the heavy use ofindexOfand I also removed onedeepExtendthat was not necessary (it was just cloning all the nodes options in the network. And it actually needed to clone none).Let me know what you guys think.
Regards