adding the option of drawing a background to the edges. #3606
Conversation
|
Please replace the initial comment with your won description, so that we know what it's about. |
yoavdamri
changed the title
There was a problem hiding this comment.
@yoavdamri Thanks very much for your contributions! We are very happy! 🎉
Can you please make sure you only change the lines of code, you really had to change.
You just can make new changes in you develop branch an push them. This PR will automatically update.
Thanks!
| @@ -1,7 +1,6 @@ | |||
| let util = require("../../../../../util"); | |||
| let EndPoints = require("./EndPoints").default; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@yoavdamri Could you please only change the lines of code that really needs to be changed. Syntax "improvements" should not be mixed with other pull requests. The only change in this file should be the drawBackground and the setStrokeDashed functions.
I know this was probably your editor that did those changes but maybe you can teach it not to this!? Thanks
| @@ -0,0 +1,67 @@ | |||
| <!doctype html> | |||
There was a problem hiding this comment.
@yoavdamri Thanks for creating an example! 🥇
docs/network/edges.html
Outdated
| @@ -4,66 +4,115 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="utf-8"> | |||
There was a problem hiding this comment.
Puh! You really should not change every line in this document! Please only add your lines. It's impossible to review like this.
add and edit only my changes
|
Sorry for the unwanted changes i commit, it is because of the idea auto formatting. |
|
LGTM! |
|
@yoavdamri But still, please change the initial comment, so we know what it's about! |
|
@wimrijnders i don't think i have to option to do it. is there a document describes howto do it? |
|
You sure about that? You are the owner of the comment, you should be able to click on the pencil icon to change it. I you really can't change it, make a new comment with a description of the PR and I'll paste it in. |
|
@yoavdamri I have to say you did a wonderful job. Thanks for updating the documentation as well and adding a demo. Not adding a unit test can be forgiven, because your addition is a visual thing. Please do come back for more changes! |
* background docs * edge background * Update edges.html * Update EdgeBase.js
Thank you for contributing to vis.js!!
Please make sure to check the following requirements before creating a pull request:
masterbranch will be closed!git fetch && git rebase origin developto update your feature branch).