This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Network: Add extra check on null value during label handling #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an oversight in almende#3486. Unit tests added, not only for null labels, but for all weird label values I could thing of.
|
'Stupid' is the word I would use. Missing something so fundamental as that.... |
|
Nah, we improve all the time. If we were perfect on the first time all the time, we wouldn't have work =P |
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
…#3511) * Network: Add extra check on null value during label handling This fixes an oversight in almende#3486. Unit tests added, not only for null labels, but for all weird label values I could thing of. * Enhanced unit tests, adjusted label check
mojoaxel
added a commit
to visjs/vis-network
that referenced
this pull request
Jul 17, 2019
via @macleodbroad-wf, @wimrijnders (almende/vis#3228, almende/vis#3470, almende/vis#3486, almende/vis#3511, almende#3520) , almende#3518, almende#3575, almende#3565, almende#3603, almende#3646)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an oversight in #3486.
Also added unit tests, not only for null labels, but for all weird label values I could thing of.