Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests won't run #142

Closed
alichtman opened this issue Oct 25, 2018 · 2 comments
Closed

Tests won't run #142

alichtman opened this issue Oct 25, 2018 · 2 comments
Labels
bug Something isn't working testing

Comments

@alichtman
Copy link
Owner

alichtman commented Oct 25, 2018 •
edited
Loading

I did a pretty large refactoring of the app. I refactored the tests to still pass with the refactors, and all was good.

I pushed and merged into master and then found out that the reason the code worked on my machine was because of a shallow-backup binary I had installed. There was a flaw with the imports that caused it to not build without the binary installed, so I pushed a fix to get master working perfectly, but (ironically) it now fails all the tests. I'm not sure how to fix this at the moment, but I'm working on it.

image

@pyasi, maybe you have an idea of what's going on here?
@alichtman alichtman added bug Something isn't working testing labels Oct 25, 2018
@alichtman
Copy link
Owner Author

Check out the old version in this commit a489f0d for a configuration that did pass the tests.

@alichtman
Copy link
Owner Author

Oh, I have to make some changes in the __init__.py file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alichtman