Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract all hardcoded filepaths to constants/functions #116

Closed
alichtman opened this issue Oct 19, 2018 · 2 comments
Closed

Extract all hardcoded filepaths to constants/functions #116

alichtman opened this issue Oct 19, 2018 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alichtman
Copy link
Owner

No description provided.

@alichtman alichtman added help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest labels Oct 19, 2018
@asiedubrempong
Copy link

I want to work on it. Can you provide a bit more details?

@alichtman alichtman changed the title Extract all hardcoded filepaths to constants Extract all hardcoded filepaths to constants/functions Oct 19, 2018
@alichtman
Copy link
Owner Author

Yeah, basically, any time there's a hardcoded path in the file, it should be extracted to get_x() type function, or a constant, whichever makes the most sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alichtman @asiedubrempong