fix(json-schema): fix single function x-reactions not work #1497

alibaba · May 25, 2021 · ae5019d · ae5019d
1 parent d5bf2ca
commit ae5019d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/json-schema/src/__tests__/schema.spec.ts b/packages/json-schema/src/__tests__/schema.spec.ts
@@ -249,3 +249,12 @@ describe('all static methods', () => {
   expect(Schema.getOrderProperties()).toEqual([])
   Schema.registerPatches(null)
 })
+
+test('single function x-reactions', () => {
+  const reactions = () => console.info('x-reactions')
+  const schema = new Schema({
+    type: 'string',
+    'x-reactions': reactions,
+  })
+  expect(schema.compile()['x-reactions']).toEqual(reactions)
+})
diff --git a/packages/json-schema/src/schema.ts b/packages/json-schema/src/schema.ts
@@ -40,7 +40,8 @@ export class Schema<
   Validator = any,
   Message = any,
   ReactionField = any
-> implements ISchema {
+> implements ISchema
+{
   parent?: Schema
   name?: SchemaKey
   title?: Message
@@ -446,7 +447,7 @@ export class Schema<
   compile = (scope?: any) => {
     const schema = new Schema({}, this.parent)
     each(this, (value, key) => {
-      if (isFn(value)) return
+      if (isFn(value) && !key.includes('x-')) return
       if (key === 'parent') return
       if (!ShallowCompileKeys.includes(key)) {
         schema[key] = value ? compile(value, scope) : value