You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The class com.alibaba.druid.sql.ast.SQLObject currently defines the method setSource like this:
setSource(intcolumn, intline)
However, the implementation in SQLObjectImpl and also all callers seem to provide (line, column) (switched parameters).
It would therefore be good to either switch the parameters in SQLObject#setSource to be (int line, int column) as well (and to match the implementation and usage), or to adjust SQLObjectImpl and all callers.
Please double-check in case I overlooked something.
I will probably not submit a pull request for this because I am not familiar with this project.
Testcase Code
No response
Stacktrace Info
No response
Error Info
No response
The text was updated successfully, but these errors were encountered:
Database Type
irrelevant
Database Version
irrelevant
Druid Version
c83288e
JDK Version
irrelevant
Error SQL
none
Description
The class
com.alibaba.druid.sql.ast.SQLObject
currently defines the methodsetSource
like this:However, the implementation in
SQLObjectImpl
and also all callers seem to provide(line, column)
(switched parameters).It would therefore be good to either switch the parameters in
SQLObject#setSource
to be(int line, int column)
as well (and to match the implementation and usage), or to adjustSQLObjectImpl
and all callers.Please double-check in case I overlooked something.
I will probably not submit a pull request for this because I am not familiar with this project.
Testcase Code
No response
Stacktrace Info
No response
Error Info
No response
The text was updated successfully, but these errors were encountered: