Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SQLObject#setSource parameters are switched #6311

Open
Marcono1234 opened this issue Dec 31, 2024 · 0 comments
Open

[BUG] SQLObject#setSource parameters are switched #6311

Marcono1234 opened this issue Dec 31, 2024 · 0 comments

Comments

@Marcono1234
Copy link

Marcono1234 commented Dec 31, 2024

Database Type

irrelevant

Database Version

irrelevant

Druid Version

c83288e

JDK Version

irrelevant

Error SQL

none

Description

The class com.alibaba.druid.sql.ast.SQLObject currently defines the method setSource like this:

setSource(int column, int line)

However, the implementation in SQLObjectImpl and also all callers seem to provide (line, column) (switched parameters).

It would therefore be good to either switch the parameters in SQLObject#setSource to be (int line, int column) as well (and to match the implementation and usage), or to adjust SQLObjectImpl and all callers.

Please double-check in case I overlooked something.

I will probably not submit a pull request for this because I am not familiar with this project.

Testcase Code

No response

Stacktrace Info

No response

Error Info

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant