improve(inventory): Support more authentication methods and Change us… #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixue323
force-pushed
the
inv
branch
2 times, most recently
from
428aa83 to
033634a
Compare
xiaozhu36
requested changes
Dec 10, 2019
contrib/inventory/alicloud.ini
Outdated
| # alicloud_profile=test | ||
| # alicloud_role_arn=acs:ram::1182725234319447:role/role_name | ||
| # alicloud_assume_role_session_name=ansible-test | ||
| # alicloud_assume_role_policy={"Statement": [{"Action": ["*"],"Effect": "Allow","Resource": "*"}],"Version": "1"} |
There was a problem hiding this comment.
既然有了assume_role了，为啥还要alicloud_role_arn，alicloud_assume_role_session_name和alicloud_assume_role_policy
这几个应该都放在assume_role 这个参数下面
contrib/inventory/alicloud.py
Outdated
| @@ -441,7 +480,7 @@ def connect_to_ecs(self, module, region): | |||
|
|
|||
| # Check module args for credentials, then check environment vars access key pair and region | |||
| connect_args = self.credentials | |||
| connect_args['user_agent'] = 'Ansible-Provider-Alicloud' | |||
| connect_args['user_agent'] = 'Ansible-Provider-Inventory' | |||
There was a problem hiding this comment.
Ansible-Provider-Alicloud/Dynamic-Inventory
xiaozhu36
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er_agent