From 8ee0d5f03baf2e45d6072106d760fe4ec9ac931b Mon Sep 17 00:00:00 2001 From: DollarB Date: Sat, 19 Mar 2022 00:13:23 +0800 Subject: [PATCH] Fix the method isValidRule in GatewayRuleManager.class has a invalid check. ControlBehavior should be checked here, not grade. (#2595) --- .../adapter/gateway/common/rule/GatewayRuleManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sentinel-adapter/sentinel-api-gateway-adapter-common/src/main/java/com/alibaba/csp/sentinel/adapter/gateway/common/rule/GatewayRuleManager.java b/sentinel-adapter/sentinel-api-gateway-adapter-common/src/main/java/com/alibaba/csp/sentinel/adapter/gateway/common/rule/GatewayRuleManager.java index dce2778a71..efc2c534da 100644 --- a/sentinel-adapter/sentinel-api-gateway-adapter-common/src/main/java/com/alibaba/csp/sentinel/adapter/gateway/common/rule/GatewayRuleManager.java +++ b/sentinel-adapter/sentinel-api-gateway-adapter-common/src/main/java/com/alibaba/csp/sentinel/adapter/gateway/common/rule/GatewayRuleManager.java @@ -119,7 +119,7 @@ public static boolean isValidRule(GatewayFlowRule rule) { || rule.getGrade() < 0 || rule.getCount() < 0 || rule.getBurst() < 0 || rule.getControlBehavior() < 0) { return false; } - if (rule.getGrade() == RuleConstant.CONTROL_BEHAVIOR_RATE_LIMITER + if (rule.getControlBehavior() == RuleConstant.CONTROL_BEHAVIOR_RATE_LIMITER && rule.getMaxQueueingTimeoutMs() < 0) { return false; }