From c1cef32965b5c8de31ad8ea5420a6f51a9d73b61 Mon Sep 17 00:00:00 2001 From: Luke Date: Wed, 16 Sep 2020 19:00:08 +0800 Subject: [PATCH 1/2] doc: Fix a description error in README.md of sentinel-dashboard --- sentinel-dashboard/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sentinel-dashboard/README.md b/sentinel-dashboard/README.md index 63de667248..ad8b91f966 100755 --- a/sentinel-dashboard/README.md +++ b/sentinel-dashboard/README.md @@ -33,7 +33,7 @@ java -Dserver.port=8080 \ | 参数 | 作用 | |--------|--------| -|`Dcsp.sentinel.dashboard.server=localhost:8080`|向 Sentinel 接入端指定控制台的地址| +|`-Dcsp.sentinel.dashboard.server=localhost:8080`|向 Sentinel 接入端指定控制台的地址| |`-Dproject.name=sentinel-dashboard`|向 Sentinel 指定应用名称，比如上面对应的应用名称就为 `sentinel-dashboard`| 全部的配置项可以参考 [启动配置项文档](https://github.com/alibaba/Sentinel/wiki/%E5%90%AF%E5%8A%A8%E9%85%8D%E7%BD%AE%E9%A1%B9)。 From 11da256b55282ca51f2b5a5e3cd681a530435bc9 Mon Sep 17 00:00:00 2001 From: Luke Date: Wed, 16 Sep 2020 22:24:12 +0800 Subject: [PATCH 2/2] Fix incorrect parameter names in VersionUtils javadoc and used more appropriate names --- .../alibaba/csp/sentinel/dashboard/util/VersionUtils.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sentinel-dashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/util/VersionUtils.java b/sentinel-dashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/util/VersionUtils.java index cb013a1249..71b9ac2750 100644 --- a/sentinel-dashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/util/VersionUtils.java +++ b/sentinel-dashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/util/VersionUtils.java @@ -32,16 +32,16 @@ public final class VersionUtils { /** * Parse version of Sentinel from raw string. * - * @param versionFull version string + * @param verStr version string * @return parsed {@link SentinelVersion} if the version is valid; empty if * there is something wrong with the format */ - public static Optional parseVersion(String s) { - if (StringUtil.isBlank(s)) { + public static Optional parseVersion(String verStr) { + if (StringUtil.isBlank(verStr)) { return Optional.empty(); } try { - String versionFull = s; + String versionFull = verStr; SentinelVersion version = new SentinelVersion(); // postfix