Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sentinel-cluster-server-envoy-rls to envoy v3 api #2156

Closed
13567436138 opened this issue Apr 23, 2021 · 4 comments · Fixed by #2336
Closed

update sentinel-cluster-server-envoy-rls to envoy v3 api #2156

13567436138 opened this issue Apr 23, 2021 · 4 comments · Fixed by #2336
Labels
area/cloud-native Issues or PRs related to cloud native architecture area/cluster-flow Issues or PRs related to cluster flow control good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.

Comments

@13567436138
Copy link

Issue Description

update sentinel-cluster-server-envoy-rls to envoy v3 api
Type: bug report or feature request

Describe what happened (or what feature you want)

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?
@sczyh30 sczyh30 added area/cloud-native Issues or PRs related to cloud native architecture area/cluster-flow Issues or PRs related to cluster flow control kind/enhancement Category issues or prs related to enhancement. good first issue Good for newcomers labels Apr 23, 2021
@sczyh30
Copy link
Member

sczyh30 commented Apr 25, 2021

Contributions are welcomed!

@winjaychan
Copy link
Contributor

winjaychan commented Aug 11, 2021 •
edited
Loading

@sczyh30 I have updated sentinel-cluster-server-envoy-rls to envoy v3 api，it supports v2 and v3 api. I have tested in the istio enviroment with v1.8.1. It works well as so for. May I make a PR for sentinel-cluster-server-envoy-rls ?

@sczyh30
Copy link
Member

sczyh30 commented Aug 11, 2021

@sczyh30 I have updated sentinel-cluster-server-envoy-rls to envoy v3 api，it supports v2 and v3 api. I have tested in the istio enviroment with v1.8.1. It works well as so for. May I make a PR for sentinel-cluster-server-envoy-rls ?

Sure. Look forward to your PR~

@winjaychan winjaychan mentioned this issue Aug 13, 2021
Merged
@winjaychan
Copy link
Contributor

@sczyh30 I have created the PR.

@sczyh30 sczyh30 linked a pull request Aug 16, 2021 that will close this issue
feat(envoy-rls): Update sentinel-cluster-server-envoy-rls to support v3 api #2336
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cloud-native Issues or PRs related to cloud native architecture area/cluster-flow Issues or PRs related to cluster flow control good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(envoy-rls): Update sentinel-cluster-server-envoy-rls to support v3 api winjaychan/Sentinel
3 participants
@sczyh30 @13567436138 @winjaychan