-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlockException attr DegradeRule not support Serialiazable ? #1017
Comments
The Dubbo Serialization need to Object implement java.io.Serializable Interface. May be you can translate the Degrade Object to json string as a temporary a solved way. |
For better separated design you'd better deal the BlockException in your integration. Because clients don't expect it and maybe don't have it be referenced. |
@linlinisme @jasonjoo2010 @sczyh30
Agree with them, if have a unified way to handle But considering as a common scene, how about making the |
But what will happen if there is no BlockException in consumer side? We should only expose common class through RPC invocation. (eg. RuntimeException) So it still need to be deal or repack. |
Dubbo ExceptionFilter has handled this circumstance, it will convert |
Yelp. |
@jasonjoo2010 Yes, it needs to be considered and provide useful information. |
Totally agree. And in my opinion we can just skip the serialization of all the information which won't be required remotely. |
It depends on what the user wants to get from the exception and what we can offer. In fact, in addition to providing which rule triggers this exception, we seem to be unable to provide other meaningful things. The exception stack here is meaningless to the user, and we have also removed it, populating it with the exception itself. So I think we might provide serialization of the rules, and then determine which serialization fields are needed for each type of rule. |
Resolved in #1794 |
sentinel core 1.6.3 jar BlockException attr DegradeRule not support Serialiazable ?
when dubbo interface method blocked throws DegradeException, and dubbo monitor interface send msg to monitor server dubbo interface , throw exception :
The text was updated successfully, but these errors were encountered: