Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent approximate counting implementation #907

Closed
henrikac opened this issue Oct 26, 2021 · 2 comments · Fixed by #913
Closed

inconsistent approximate counting implementation #907

henrikac opened this issue Oct 26, 2021 · 2 comments · Fixed by #913

Comments

@henrikac
Copy link
Contributor

henrikac commented Oct 26, 2021

The Approximate Counting algorithm currently has four implementations and four different ways of how to act on the result of abs((avg - n_items) / n_items) < threshold.

Julia What it does
Julia Returns true or false
Python prints "passed" if the condition is true
C++ returns "pass" if the condition is true, otherwise "fail"
C aborts program execution
@leios
Copy link
Member

leios commented Oct 26, 2021

I have been wrapping all the Julia code into @testsets do get a pass and fail of each test; however, this raises a good point. For consistency with other languages, maybe we should adopt something less language specific.

@henrikac
Copy link
Contributor Author

henrikac commented Oct 26, 2021

For consistency with other languages, maybe we should adopt something less language specific

A standardization of the output/behaviour as a minimum would be good idea (imo), otherwise it might end up like #857 when more languages get implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants