Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strings.Cut once we upgrade to 1.18 #4531

Closed
jannotti opened this issue Sep 12, 2022 · 2 comments
Closed

Use strings.Cut once we upgrade to 1.18 #4531

jannotti opened this issue Sep 12, 2022 · 2 comments

Comments

@jannotti
Copy link
Contributor

strings.Cut was added in Go 1.18, it could simplifiy some code, like in logic/parsing.go
@jannotti
Copy link
Contributor Author

Nice discussion of some patterns to reconsider:
golang/go#46336

@winder
Copy link
Contributor

winder commented Sep 29, 2022

Duplicate of #4532

@winder winder closed this as completed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@winder @jannotti