Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

feat(insights): expose send-event in widgets #953

Merged
merged 4 commits into from
Apr 21, 2021
Merged

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Apr 14, 2021

Summary

This PR exposes send-event in the following widgets:

  • HierarchicalMenu
  • Hits
  • InfiniteHits
  • Menu
  • MenuSelect
  • NumericMenu
  • RangeInput
  • RatingMenu
  • RefinementList
  • ToggleRefinement

By supporting the middlewares API in the recent change, the insights middleware works with Vue InstantSearch but with this PR, we can let users write custom components and still utilize sendEvent method.

TODO

  • Add tests

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 14, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cfe0e4c:

Sandbox Source
vue-instantsearch-e-commerce Configuration
pedantic-dawn-v7ld2 PR

@eunjae-lee eunjae-lee marked this pull request as ready for review April 20, 2021 12:36
@eunjae-lee eunjae-lee requested review from tkrugg and Haroenv April 20, 2021 12:36
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing to remark!

@eunjae-lee eunjae-lee merged commit e2e42a4 into master Apr 21, 2021
@eunjae-lee eunjae-lee deleted the feat/insights branch April 21, 2021 08:24
Haroenv pushed a commit to algolia/instantsearch that referenced this pull request Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants