Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

feat(ssr): forward router instance to findResultsState clone #863

Merged
merged 4 commits into from
Sep 23, 2020

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Sep 22, 2020

in our guide for routing with vue router, you need to access the Vue Router instance. The most straightforward way for that is to move the construction of the server mixin into data(). router is useful for creating an instantsearch router compatible with vueRouter

Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@Haroenv Haroenv merged commit 84f79eb into master Sep 23, 2020
@Haroenv Haroenv deleted the fix/vue-router-ssr branch September 23, 2020 13:27
Haroenv added a commit to algolia/instantsearch that referenced this pull request Dec 28, 2022
…/vue-instantsearch#863)

* feat(ssr): forward router instance to findResultsState clone

* test: assert that $router is accessible

* chore(refactor): smaller

* pin dependency
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants