This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(SearchBox): propagate the classname overrides to children #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never noticed it because this wasn't a very popular API, but if you use vanilla ais-search-box, you can not override the class names of the input or the clear which are nested within the component. This is not an issue we have in v2, since we removed this API and no longer nest components in eachother, so it doesn't need to be passed around. Using the `:class-names` API to pretend v1 is using InstantSearch.css with @francoischalifour made me realise that this is a useful API to keep, so it should be replicated in v2 as well.
Haroenv
force-pushed
the
fix/searchbox-classes
branch
from
2e79451 to
98a0b91
Compare
Haroenv
added a commit
that referenced
this pull request
May 29, 2018
* fix(SearchBox): propagate the classname overrides to children We never noticed it because this wasn't a very popular API, but if you use vanilla ais-search-box, you can not override the class names of the input or the clear which are nested within the component. This is not an issue we have in v2, since we removed this API and no longer nest components in eachother, so it doesn't need to be passed around. Using the `:class-names` API to pretend v1 is using InstantSearch.css with @francoischalifour made me realise that this is a useful API to keep, so it should be replicated in v2 as well. * test: update snapshots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never noticed it because this wasn't a very popular API, but if you use vanilla ais-search-box, you can not override the class names of the input or the clear which are nested within the component.
This is not an issue we have in v2, since we removed this API and no longer nest components in eachother, so it doesn't need to be passed around.
Using the
:class-namesAPI to pretend v1 is using InstantSearch.css with @francoischalifour made me realise that this is a useful API to keep, so it should be replicated in v2 as well.(this change was tested in @francoischalifour's node_modules)