This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(Stats): add more info to slot #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add resultStart, resultEnd
Adding resultStart and resultEnd gives you "Amazon Like" stats. For example "Showing {{ resultStart }} - {{ resultEnd }} of {{ totalResults }}" would show "Showing 31 - 60 of 123" when you are on page 2 with 30 / page.
* forgot rename
* updated slot example
* Reverted slot example, left slot vars
* undefined checks
If this is really what you wanted, I wonder why the original 3 computed properties didn't have these checks.
* trying to make pretty happy..
|
Basically this PR is fine to merge, in a later version we can replace |
Haroenv
added a commit
that referenced
this pull request
May 29, 2018
* feat(Stats): add more info to slot (#449) * Add resultStart, resultEnd Adding resultStart and resultEnd gives you "Amazon Like" stats. For example "Showing {{ resultStart }} - {{ resultEnd }} of {{ totalResults }}" would show "Showing 31 - 60 of 123" when you are on page 2 with 30 / page. * forgot rename * updated slot example * Reverted slot example, left slot vars * undefined checks If this is really what you wanted, I wonder why the original 3 computed properties didn't have these checks. * trying to make pretty happy.. * Tweaks for resultStart/End (#450) per #449 * test(Stats): text with correct search store
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #449 and #450 for detailed info