This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(StateResults): give access to status and error #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FX-1770 Note that this changes the implementation from connectStateResults to a render listener, as `loading` is otherwise inconsistently visible. This means it will no longer be counted in metadata. Updated the helper in devDep to use ^ to avoid a duplicate with the InstantSearch.js version
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7e6e5f8:
|
dhayab
approved these changes
Oct 3, 2022
aymeric-giraudet
approved these changes
Oct 3, 2022
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…antsearch#1151) * feat(StateResults): give access to status and error FX-1770 Note that this changes the implementation from connectStateResults to a render listener, as `loading` is otherwise inconsistently visible. This means it will no longer be counted in metadata. Updated the helper in devDep to use ^ to avoid a duplicate with the InstantSearch.js version * up margin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-1770
Note that this changes the implementation from connectStateResults to a render listener, as
loadingis otherwise inconsistently visible. This means it will no longer be counted in metadata.Updated the helper in devDep to use ^ to avoid a duplicate with the InstantSearch.js version