This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(can-refine): provide canRefine for multiple widget slots
#1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…panel `canRefine`
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1eb35a0:
|
dhayab
reviewed
Aug 31, 2022
src/components/HitsPerPage.vue
Outdated
| @@ -43,7 +44,7 @@ export default { | |||
| } | |||
| ), | |||
| createPanelConsumerMixin({ | |||
| mapStateToCanRefine: state => state.hasNoResults === false, | |||
| mapStateToCanRefine: state => Boolean(state.canRefine), | |||
There was a problem hiding this comment.
Isn't state.canRefine already a boolean?
There was a problem hiding this comment.
Not always, it might be undefined, see here : #876
Should I maybe mention it in a comment or would it be redundant ?
There was a problem hiding this comment.
I see, thanks! I don't think there is a need to add a comment in that case.
Haroenv
reviewed
Sep 5, 2022
Co-authored-by: Haroen Viaene <hello@haroen.me>
dhayab
approved these changes
Sep 6, 2022
Haroenv
approved these changes
Sep 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following FX-740, we want to provide
canRefineto slots and use it forcreatePanelConsumerMixin()