feat(ssr): prevent initial network request #1106
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 19d0791:
|
Haroenv
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
Same as #1090, but for Vue InstantSearch v3
Haroenv
force-pushed
the
feat/v3-prevent-initial-request
branch
from
c269cd8 to
19d0791
Compare
| }) | ||
| ), | ||
| scopedResults: parent.getScopedResults(), | ||
| parent, |
There was a problem hiding this comment.
Any reason why we used not to pass parent?
There was a problem hiding this comment.
only index used it, and before this PR, index was manually init/rendered in __forceWidget, meaning it didn't really do anything :)
|
|
||
| it('accepts non-stringified results', () => { | ||
| describe('hydrate', () => { | ||
| it('sets _initialResults', () => { |
There was a problem hiding this comment.
I see there was a conversation to discard this test here, but it wasn't removed in the end. Any reason not to? Anything that it tests that isn't covered elsewhere?
There was a problem hiding this comment.
It's indeed testing some InstantSearch internals, but the main reason it stayed is that Vue InstantSearch is extending InstantSearch with a couple methods, which could in theory cause hydrate not to work correctly anymore
Same as #1090, but for Vue InstantSearch v3
fixes #1066
fixes #1062
closes algolia/instantsearch#5002