This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(server): extend component correctly if at root #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Haroenv
force-pushed
the
fix/ssr-root-v3
branch
from
d8fc011 to
31526b8
Compare
Haroenv
commented
Jan 31, 2022
Haroenv
requested review from
sarahdayan,
a team and
dhayab
and removed request for
a team
dhayab
approved these changes
Jan 31, 2022
sarahdayan
approved these changes
Jan 31, 2022
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
This was referenced Jan 31, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially the problem is that $vnode is usually available, but not when the this is a root Vue instance. In that case we are in the "Vue.component" case, which before now always was wrong (it takes two arguments, not one)
Same as #1104
see also #1054