fix(recommend): use Hit type instead of AlgoliaHit #6540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up on #6533
When using
sendEvent
with Recommend in InstantSearch.js we encounter a typing issuecodesandbox to demonstrate the type issue https://codesandbox.io/p/sandbox/nzkfh7
This is because
AlgoliaHit
is only meant for hits that don't first go throughaddAbsolutePosition
andaddQueryId
. This means that the type we actually mean to use is Hit in most cases.Result
The issue was not caught by
yarn type-check
initially, I'm not sure how we could have done better to automatically catch it.