From 71973305d8a2c70f5a2a4c8cbc94b2cc78eed98d Mon Sep 17 00:00:00 2001
From: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Date: Tue, 7 Mar 2023 17:39:08 +0100
Subject: [PATCH 1/6] feat(createAlgoliaInsightsPlugin): automatically load
Insights when not passed
---
package.json | 1 +
.../createAlgoliaInsightsPlugin.test.ts | 131 +++++++++++++++++-
.../src/createAlgoliaInsightsPlugin.ts | 58 +++++++-
.../src/types/InsightsClient.ts | 31 ++++-
.../src/__tests__/safelyRunOnBrowser.test.ts | 64 +++++++++
packages/autocomplete-shared/src/index.ts | 1 +
.../src/safelyRunOnBrowser.ts | 24 ++++
yarn.lock | 5 +
8 files changed, 310 insertions(+), 5 deletions(-)
create mode 100644 packages/autocomplete-shared/src/__tests__/safelyRunOnBrowser.test.ts
create mode 100644 packages/autocomplete-shared/src/safelyRunOnBrowser.ts
diff --git a/package.json b/package.json
index 1823c6a60..1c8521a14 100644
--- a/package.json
+++ b/package.json
@@ -91,6 +91,7 @@
"rollup-plugin-filesize": "9.1.2",
"rollup-plugin-license": "2.9.1",
"rollup-plugin-terser": "7.0.2",
+ "search-insights": "2.3.0",
"shipjs": "0.24.1",
"start-server-and-test": "1.15.2",
"stylelint": "13.13.1",
diff --git a/packages/autocomplete-plugin-algolia-insights/src/__tests__/createAlgoliaInsightsPlugin.test.ts b/packages/autocomplete-plugin-algolia-insights/src/__tests__/createAlgoliaInsightsPlugin.test.ts
index 00dcad110..f604aa89c 100644
--- a/packages/autocomplete-plugin-algolia-insights/src/__tests__/createAlgoliaInsightsPlugin.test.ts
+++ b/packages/autocomplete-plugin-algolia-insights/src/__tests__/createAlgoliaInsightsPlugin.test.ts
@@ -4,6 +4,7 @@ import {
getAlgoliaResults,
} from '@algolia/autocomplete-preset-algolia';
import { noop } from '@algolia/autocomplete-shared';
+import { fireEvent } from '@testing-library/dom';
import userEvent from '@testing-library/user-event';
import insightsClient from 'search-insights';
@@ -12,11 +13,17 @@ import {
createPlayground,
createSearchClient,
createSource,
+ defer,
runAllMicroTasks,
} from '../../../../test/utils';
import { createAlgoliaInsightsPlugin } from '../createAlgoliaInsightsPlugin';
-jest.useFakeTimers();
+beforeEach(() => {
+ (window as any).AlgoliaAnalyticsObject = undefined;
+ (window as any).aa = undefined;
+
+ document.body.innerHTML = '';
+});
describe('createAlgoliaInsightsPlugin', () => {
test('has a name', () => {
@@ -70,7 +77,7 @@ describe('createAlgoliaInsightsPlugin', () => {
);
});
- test('sets a user agent on the Insights client on subscribe', () => {
+ test('sets a user agent on on subscribe', () => {
const insightsClient = jest.fn();
const insightsPlugin = createAlgoliaInsightsPlugin({ insightsClient });
@@ -167,7 +174,127 @@ describe('createAlgoliaInsightsPlugin', () => {
]);
});
+ describe('automatic pulling', () => {
+ const consoleError = jest
+ .spyOn(console, 'error')
+ .mockImplementation(() => {});
+
+ afterAll(() => {
+ consoleError.mockReset();
+ });
+
+ it('does not load the script when the Insights client is passed', async () => {
+ createPlayground(createAutocomplete, {
+ plugins: [createAlgoliaInsightsPlugin({ insightsClient: noop })],
+ });
+
+ await defer(noop, 0);
+
+ expect(document.body).toMatchInlineSnapshot(`
+
+
+
+ `);
+ expect((window as any).AlgoliaAnalyticsObject).toBe(undefined);
+ expect((window as any).aa).toBe(undefined);
+ });
+
+ it('does not load the script when the Insights client is present in the page', async () => {
+ (window as any).AlgoliaAnalyticsObject = 'aa';
+ const aa = noop;
+ (window as any).aa = aa;
+
+ createPlayground(createAutocomplete, {
+ plugins: [createAlgoliaInsightsPlugin({})],
+ });
+
+ await defer(noop, 0);
+
+ expect(document.body).toMatchInlineSnapshot(`
+
+
+
+ `);
+ expect((window as any).AlgoliaAnalyticsObject).toBe('aa');
+ expect((window as any).aa).toBe(aa);
+ });
+
+ it('loads the script when the Insights client is not passed and not present in the page', async () => {
+ createPlayground(createAutocomplete, {
+ plugins: [createAlgoliaInsightsPlugin({})],
+ });
+
+ await defer(noop, 0);
+
+ expect(document.body).toMatchInlineSnapshot(`
+
+
+
+
+ `);
+ expect((window as any).AlgoliaAnalyticsObject).toBe('aa');
+ expect((window as any).aa).toEqual(expect.any(Function));
+ });
+
+ it('notifies when the script fails to be added', () => {
+ // @ts-ignore `createElement` is a class method can thus only be called on
+ // an instance of `Document`, not as a standalone function.
+ // This is needed to call the actual implementation later in the test.
+ document.originalCreateElement = document.createElement;
+
+ document.createElement = (tagName) => {
+ if (tagName === 'script') {
+ throw new Error('error');
+ }
+
+ // @ts-ignore
+ return document.originalCreateElement(tagName);
+ };
+
+ createPlayground(createAutocomplete, {
+ plugins: [createAlgoliaInsightsPlugin({})],
+ });
+
+ expect(consoleError).toHaveBeenCalledWith(
+ '[Autocomplete]: Could not load search-insights.js. Please load it manually following https://alg.li/insights-autocomplete'
+ );
+
+ // @ts-ignore
+ document.createElement = document.originalCreateElement;
+ });
+
+ it('notifies when the script fails to load', async () => {
+ createPlayground(createAutocomplete, {
+ plugins: [createAlgoliaInsightsPlugin({})],
+ });
+
+ await defer(noop, 0);
+
+ fireEvent(document.querySelector('script')!, new ErrorEvent('error'));
+
+ expect(consoleError).toHaveBeenCalledWith(
+ '[Autocomplete]: Could not load search-insights.js. Please load it manually following https://alg.li/insights-autocomplete'
+ );
+ });
+ });
+
describe('onItemsChange', () => {
+ beforeAll(() => {
+ jest.useFakeTimers();
+ });
+
+ afterAll(() => {
+ jest.useRealTimers();
+ });
+
test('sends a `viewedObjectIDs` event by default', async () => {
const insightsClient = jest.fn();
const insightsPlugin = createAlgoliaInsightsPlugin({ insightsClient });
diff --git a/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts b/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
index b58102b37..dda2f7251 100644
--- a/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
+++ b/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
@@ -7,6 +7,7 @@ import {
debounce,
isEqual,
noop,
+ safelyRunOnBrowser,
} from '@algolia/autocomplete-shared';
import { createClickedEvent } from './createClickedEvent';
@@ -23,6 +24,8 @@ import {
} from './types';
const VIEW_EVENT_DELAY = 400;
+const ALGOLIA_INSIGHTS_VERSION = '2.3.0';
+const ALGOLIA_INSIGHTS_SRC = `https://cdn.jsdelivr.net/npm/search-insights@${ALGOLIA_INSIGHTS_VERSION}/dist/search-insights.min.js`;
type SendViewedObjectIDsParams = {
onItemsChange(params: OnItemsChangeParams): void;
@@ -51,7 +54,7 @@ export type CreateAlgoliaInsightsPluginParams = {
*
* @link https://www.algolia.com/doc/ui-libraries/autocomplete/api-reference/autocomplete-plugin-algolia-insights/createAlgoliaInsightsPlugin/#param-insightsclient
*/
- insightsClient: InsightsClient;
+ insightsClient?: InsightsClient;
/**
* Hook to send an Insights event when the items change.
*
@@ -84,11 +87,41 @@ export function createAlgoliaInsightsPlugin(
options: CreateAlgoliaInsightsPluginParams
): AutocompletePlugin {
const {
- insightsClient,
+ insightsClient: providedInsightsClient,
onItemsChange,
onSelect: onSelectEvent,
onActive: onActiveEvent,
} = getOptions(options);
+ let insightsClient: InsightsClient = providedInsightsClient || noop;
+
+ if (!providedInsightsClient) {
+ safelyRunOnBrowser(({ window }) => {
+ const pointer = window.AlgoliaAnalyticsObject || 'aa';
+
+ if (typeof pointer === 'string') {
+ insightsClient = window[pointer];
+ }
+
+ if (!insightsClient) {
+ window.AlgoliaAnalyticsObject = pointer;
+
+ if (!window[pointer]) {
+ window[pointer] = (...args: any[]) => {
+ if (!window[pointer].queue) {
+ window[pointer].queue = [];
+ }
+
+ window[pointer].queue.push(args);
+ };
+ }
+
+ insightsClient = window[pointer];
+
+ loadInsights(window);
+ }
+ });
+ }
+
const insights = createSearchInsightsApi(insightsClient);
const previousItems = createRef([]);
@@ -180,6 +213,7 @@ export function createAlgoliaInsightsPlugin(
function getOptions(options: CreateAlgoliaInsightsPluginParams) {
return {
+ // insightsClient: noop,
onItemsChange({ insights, insightsEvents }) {
insights.viewedObjectIDs(...insightsEvents);
},
@@ -190,3 +224,23 @@ function getOptions(options: CreateAlgoliaInsightsPluginParams) {
...options,
};
}
+
+function loadInsights(environment: typeof window) {
+ const errorMessage = `[Autocomplete]: Could not load search-insights.js. Please load it manually following https://alg.li/insights-autocomplete`;
+
+ try {
+ const script = environment.document.createElement('script');
+ script.async = true;
+ script.src = ALGOLIA_INSIGHTS_SRC;
+
+ script.onerror = () => {
+ // eslint-disable-next-line no-console
+ console.error(errorMessage);
+ };
+
+ document.body.appendChild(script);
+ } catch (cause) {
+ // eslint-disable-next-line no-console
+ console.error(errorMessage);
+ }
+}
diff --git a/packages/autocomplete-plugin-algolia-insights/src/types/InsightsClient.ts b/packages/autocomplete-plugin-algolia-insights/src/types/InsightsClient.ts
index 8eb9865e0..9490c7360 100644
--- a/packages/autocomplete-plugin-algolia-insights/src/types/InsightsClient.ts
+++ b/packages/autocomplete-plugin-algolia-insights/src/types/InsightsClient.ts
@@ -1 +1,30 @@
-export type InsightsClient = any;
+import type {
+ InsightsMethodMap,
+ InsightsClient as _InsightsClient,
+} from 'search-insights';
+
+export type {
+ Init as InsightsInit,
+ AddAlgoliaAgent as InsightsAddAlgoliaAgent,
+ SetUserToken as InsightsSetUserToken,
+ GetUserToken as InsightsGetUserToken,
+ OnUserTokenChange as InsightsOnUserTokenChange,
+} from 'search-insights';
+
+export type InsightsClientMethod = keyof InsightsMethodMap;
+
+export type InsightsClientPayload = {
+ eventName: string;
+ queryID: string;
+ index: string;
+ objectIDs: string[];
+ positions?: number[];
+};
+
+type QueueItemMap = Record;
+
+type QueueItem = QueueItemMap[keyof QueueItemMap];
+
+export type InsightsClient = _InsightsClient & {
+ queue?: QueueItem[];
+};
diff --git a/packages/autocomplete-shared/src/__tests__/safelyRunOnBrowser.test.ts b/packages/autocomplete-shared/src/__tests__/safelyRunOnBrowser.test.ts
new file mode 100644
index 000000000..0fe6c2ca6
--- /dev/null
+++ b/packages/autocomplete-shared/src/__tests__/safelyRunOnBrowser.test.ts
@@ -0,0 +1,64 @@
+import { safelyRunOnBrowser } from '../safelyRunOnBrowser';
+
+type CallbackReturn = {
+ env: 'client' | 'server';
+};
+
+const CLIENT = 'client' as const;
+const SERVER = 'server' as const;
+
+describe('safelyRunOnBrowser', () => {
+ const originalWindow = (global as any).window;
+
+ afterEach(() => {
+ (global as any).window = originalWindow;
+ });
+
+ test('runs callback on browsers', () => {
+ const callback = jest.fn(() => ({ env: CLIENT }));
+
+ const result = safelyRunOnBrowser(callback);
+
+ expect(callback).toHaveBeenCalledTimes(1);
+ expect(callback).toHaveBeenCalledWith({ window });
+ expect(result).toEqual({ env: 'client' });
+ });
+
+ test('does not run fallback on browsers', () => {
+ const callback = jest.fn(() => ({ env: CLIENT }));
+ const fallback = jest.fn(() => ({ env: SERVER }));
+
+ const result = safelyRunOnBrowser(callback, { fallback });
+
+ expect(callback).toHaveBeenCalledTimes(1);
+ expect(callback).toHaveBeenCalledWith({ window });
+ expect(fallback).toHaveBeenCalledTimes(0);
+ expect(result).toEqual({ env: 'client' });
+ });
+
+ test('does not run callback on servers', () => {
+ // @ts-expect-error
+ delete global.window;
+
+ const callback = jest.fn(() => ({ env: CLIENT }));
+
+ const result = safelyRunOnBrowser(callback);
+
+ expect(callback).toHaveBeenCalledTimes(0);
+ expect(result).toBeUndefined();
+ });
+
+ test('runs fallback on servers', () => {
+ // @ts-expect-error
+ delete global.window;
+
+ const callback = jest.fn(() => ({ env: CLIENT }));
+ const fallback = jest.fn(() => ({ env: SERVER }));
+
+ const result = safelyRunOnBrowser(callback, { fallback });
+
+ expect(callback).toHaveBeenCalledTimes(0);
+ expect(fallback).toHaveBeenCalledTimes(1);
+ expect(result).toEqual({ env: 'server' });
+ });
+});
diff --git a/packages/autocomplete-shared/src/index.ts b/packages/autocomplete-shared/src/index.ts
index 2f849f4cd..67131c3ef 100644
--- a/packages/autocomplete-shared/src/index.ts
+++ b/packages/autocomplete-shared/src/index.ts
@@ -9,6 +9,7 @@ export * from './invariant';
export * from './isEqual';
export * from './MaybePromise';
export * from './noop';
+export * from './safelyRunOnBrowser';
export * from './UserAgent';
export * from './userAgents';
export * from './version';
diff --git a/packages/autocomplete-shared/src/safelyRunOnBrowser.ts b/packages/autocomplete-shared/src/safelyRunOnBrowser.ts
new file mode 100644
index 000000000..c222c531a
--- /dev/null
+++ b/packages/autocomplete-shared/src/safelyRunOnBrowser.ts
@@ -0,0 +1,24 @@
+type BrowserCallback = (params: { window: typeof window }) => TReturn;
+
+type SafelyRunOnBrowserOptions = {
+ /**
+ * Fallback to run on server environments.
+ */
+ fallback: () => TReturn;
+};
+
+/**
+ * Safely runs code meant for browser environments only.
+ */
+export function safelyRunOnBrowser(
+ callback: BrowserCallback,
+ { fallback }: SafelyRunOnBrowserOptions = {
+ fallback: () => (undefined as unknown) as TReturn,
+ }
+): TReturn {
+ if (typeof window === 'undefined') {
+ return fallback();
+ }
+
+ return callback({ window });
+}
diff --git a/yarn.lock b/yarn.lock
index 9d2fcbf2f..f84aff960 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -19226,6 +19226,11 @@ search-insights@1.7.1:
resolved "https://registry.yarnpkg.com/search-insights/-/search-insights-1.7.1.tgz#eddfa56910e28cbbb0df80aec2ab8acf0a86cb6b"
integrity sha512-CSuSKIJp+WcSwYrD9GgIt1e3xmI85uyAefC4/KYGgtvNEm6rt4kBGilhVRmTJXxRE2W1JknvP598Q7SMhm7qKA==
+search-insights@2.3.0:
+ version "2.3.0"
+ resolved "https://registry.yarnpkg.com/search-insights/-/search-insights-2.3.0.tgz#9a7bb25428fc7f003bafdb5638e90276113daae6"
+ integrity sha512-0v/TTO4fbd6I91sFBK/e2zNfD0f51A+fMoYNkMplmR77NpThUye/7gIxNoJ3LejKpZH6Z2KNBIpxxFmDKj10Yw==
+
search-insights@^2.1.0:
version "2.2.1"
resolved "https://registry.yarnpkg.com/search-insights/-/search-insights-2.2.1.tgz#9c93344fbae5fbf2f88c1a81b46b4b5d888c11f7"
From e58d445cca3647ab5db3767f57a39c4173debf65 Mon Sep 17 00:00:00 2001
From: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Date: Wed, 8 Mar 2023 16:57:44 +0100
Subject: [PATCH 2/6] chore(bundlesize): increase plugin size
---
bundlesize.config.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bundlesize.config.json b/bundlesize.config.json
index 40af35a20..154e4dce4 100644
--- a/bundlesize.config.json
+++ b/bundlesize.config.json
@@ -14,7 +14,7 @@
},
{
"path": "packages/autocomplete-plugin-algolia-insights/dist/umd/index.production.js",
- "maxSize": "2.1 kB"
+ "maxSize": "2.5 kB"
},
{
"path": "packages/autocomplete-plugin-redirect-url/dist/umd/index.production.js",
From b573a3df658b5db5ce5b4b635d181870f66b327e Mon Sep 17 00:00:00 2001
From: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Date: Thu, 9 Mar 2023 15:40:31 +0100
Subject: [PATCH 3/6] chore: remove unnecessary fallback
---
.../src/__tests__/safelyRunOnBrowser.test.ts | 41 ++-----------------
.../src/safelyRunOnBrowser.ts | 20 +++------
2 files changed, 9 insertions(+), 52 deletions(-)
diff --git a/packages/autocomplete-shared/src/__tests__/safelyRunOnBrowser.test.ts b/packages/autocomplete-shared/src/__tests__/safelyRunOnBrowser.test.ts
index 0fe6c2ca6..7bb54fa2f 100644
--- a/packages/autocomplete-shared/src/__tests__/safelyRunOnBrowser.test.ts
+++ b/packages/autocomplete-shared/src/__tests__/safelyRunOnBrowser.test.ts
@@ -1,12 +1,5 @@
import { safelyRunOnBrowser } from '../safelyRunOnBrowser';
-type CallbackReturn = {
- env: 'client' | 'server';
-};
-
-const CLIENT = 'client' as const;
-const SERVER = 'server' as const;
-
describe('safelyRunOnBrowser', () => {
const originalWindow = (global as any).window;
@@ -15,24 +8,12 @@ describe('safelyRunOnBrowser', () => {
});
test('runs callback on browsers', () => {
- const callback = jest.fn(() => ({ env: CLIENT }));
-
- const result = safelyRunOnBrowser(callback);
-
- expect(callback).toHaveBeenCalledTimes(1);
- expect(callback).toHaveBeenCalledWith({ window });
- expect(result).toEqual({ env: 'client' });
- });
-
- test('does not run fallback on browsers', () => {
- const callback = jest.fn(() => ({ env: CLIENT }));
- const fallback = jest.fn(() => ({ env: SERVER }));
+ const callback = jest.fn(() => ({ env: 'client' }));
- const result = safelyRunOnBrowser(callback, { fallback });
+ const result = safelyRunOnBrowser(callback);
expect(callback).toHaveBeenCalledTimes(1);
expect(callback).toHaveBeenCalledWith({ window });
- expect(fallback).toHaveBeenCalledTimes(0);
expect(result).toEqual({ env: 'client' });
});
@@ -40,25 +21,11 @@ describe('safelyRunOnBrowser', () => {
// @ts-expect-error
delete global.window;
- const callback = jest.fn(() => ({ env: CLIENT }));
+ const callback = jest.fn(() => ({ env: 'client' }));
- const result = safelyRunOnBrowser(callback);
+ const result = safelyRunOnBrowser(callback);
expect(callback).toHaveBeenCalledTimes(0);
expect(result).toBeUndefined();
});
-
- test('runs fallback on servers', () => {
- // @ts-expect-error
- delete global.window;
-
- const callback = jest.fn(() => ({ env: CLIENT }));
- const fallback = jest.fn(() => ({ env: SERVER }));
-
- const result = safelyRunOnBrowser(callback, { fallback });
-
- expect(callback).toHaveBeenCalledTimes(0);
- expect(fallback).toHaveBeenCalledTimes(1);
- expect(result).toEqual({ env: 'server' });
- });
});
diff --git a/packages/autocomplete-shared/src/safelyRunOnBrowser.ts b/packages/autocomplete-shared/src/safelyRunOnBrowser.ts
index c222c531a..20a31ea99 100644
--- a/packages/autocomplete-shared/src/safelyRunOnBrowser.ts
+++ b/packages/autocomplete-shared/src/safelyRunOnBrowser.ts
@@ -1,24 +1,14 @@
type BrowserCallback = (params: { window: typeof window }) => TReturn;
-type SafelyRunOnBrowserOptions = {
- /**
- * Fallback to run on server environments.
- */
- fallback: () => TReturn;
-};
-
/**
* Safely runs code meant for browser environments only.
*/
export function safelyRunOnBrowser(
- callback: BrowserCallback,
- { fallback }: SafelyRunOnBrowserOptions = {
- fallback: () => (undefined as unknown) as TReturn,
- }
-): TReturn {
- if (typeof window === 'undefined') {
- return fallback();
+ callback: BrowserCallback
+): TReturn | undefined {
+ if (typeof window !== 'undefined') {
+ return callback({ window });
}
- return callback({ window });
+ return undefined;
}
From cbcd7bcf771748c657f80fb40af6bec474ffe834 Mon Sep 17 00:00:00 2001
From: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Date: Thu, 9 Mar 2023 15:49:10 +0100
Subject: [PATCH 4/6] chore: remove leftover comment
---
.../src/createAlgoliaInsightsPlugin.ts | 1 -
1 file changed, 1 deletion(-)
diff --git a/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts b/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
index dda2f7251..cf3a7c183 100644
--- a/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
+++ b/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
@@ -213,7 +213,6 @@ export function createAlgoliaInsightsPlugin(
function getOptions(options: CreateAlgoliaInsightsPluginParams) {
return {
- // insightsClient: noop,
onItemsChange({ insights, insightsEvents }) {
insights.viewedObjectIDs(...insightsEvents);
},
From 66e45f0f8f494a6712ffb2059a75c3164a7e440d Mon Sep 17 00:00:00 2001
From: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Date: Thu, 9 Mar 2023 17:37:23 +0100
Subject: [PATCH 5/6] chore: no need for noop
---
.../src/createAlgoliaInsightsPlugin.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts b/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
index cf3a7c183..ad4d2a13d 100644
--- a/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
+++ b/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
@@ -92,7 +92,7 @@ export function createAlgoliaInsightsPlugin(
onSelect: onSelectEvent,
onActive: onActiveEvent,
} = getOptions(options);
- let insightsClient: InsightsClient = providedInsightsClient || noop;
+ let insightsClient = providedInsightsClient as InsightsClient;
if (!providedInsightsClient) {
safelyRunOnBrowser(({ window }) => {
From 6a51c8352bac386427f1970271bb911b313be198 Mon Sep 17 00:00:00 2001
From: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Date: Mon, 13 Mar 2023 11:05:51 +0100
Subject: [PATCH 6/6] feat: add version
---
.../src/__tests__/createAlgoliaInsightsPlugin.test.ts | 6 ++++--
.../src/createAlgoliaInsightsPlugin.ts | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/packages/autocomplete-plugin-algolia-insights/src/__tests__/createAlgoliaInsightsPlugin.test.ts b/packages/autocomplete-plugin-algolia-insights/src/__tests__/createAlgoliaInsightsPlugin.test.ts
index f604aa89c..9b31d7170 100644
--- a/packages/autocomplete-plugin-algolia-insights/src/__tests__/createAlgoliaInsightsPlugin.test.ts
+++ b/packages/autocomplete-plugin-algolia-insights/src/__tests__/createAlgoliaInsightsPlugin.test.ts
@@ -197,8 +197,8 @@ describe('createAlgoliaInsightsPlugin', () => {
`);
- expect((window as any).AlgoliaAnalyticsObject).toBe(undefined);
- expect((window as any).aa).toBe(undefined);
+ expect((window as any).AlgoliaAnalyticsObject).toBeUndefined();
+ expect((window as any).aa).toBeUndefined();
});
it('does not load the script when the Insights client is present in the page', async () => {
@@ -221,6 +221,7 @@ describe('createAlgoliaInsightsPlugin', () => {
`);
expect((window as any).AlgoliaAnalyticsObject).toBe('aa');
expect((window as any).aa).toBe(aa);
+ expect((window as any).aa.version).toBeUndefined();
});
it('loads the script when the Insights client is not passed and not present in the page', async () => {
@@ -242,6 +243,7 @@ describe('createAlgoliaInsightsPlugin', () => {
`);
expect((window as any).AlgoliaAnalyticsObject).toBe('aa');
expect((window as any).aa).toEqual(expect.any(Function));
+ expect((window as any).aa.version).toBe('2.3.0');
});
it('notifies when the script fails to be added', () => {
diff --git a/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts b/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
index ad4d2a13d..686c43fdc 100644
--- a/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
+++ b/packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
@@ -115,6 +115,8 @@ export function createAlgoliaInsightsPlugin(
};
}
+ window[pointer].version = ALGOLIA_INSIGHTS_VERSION;
+
insightsClient = window[pointer];
loadInsights(window);