fix(render): pass renderer.render to default render function
#940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7c2f351:
|
Haroenv
approved these changes
Apr 8, 2022
| render({ children }, root) { | ||
| render(children as ReactElement, root); | ||
| }, | ||
| renderer: { createElement, Fragment, render: render as Render }, |
There was a problem hiding this comment.
why is the cast needed? is the type too narrow to accept react's render?
There was a problem hiding this comment.
Yes, but it's assignable to Render so the cast is valid.
Comment on lines
+57
to
58
| const defaultRender: AutocompleteRender<any> = ({ children, render }, root) => { | ||
| render(children, root); |
There was a problem hiding this comment.
this here is the actual fix right?
There was a problem hiding this comment.
Yes, the rest is just type updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when using the
rendereroption without therenderoption.Since #920 you no longer need to pass the
renderoption; instead you can pass a customrenderfunction via therendereroption. This caused a bug with custom VDOM implementations becauserenderwasn't passed to the internaldefaultRenderfunction, and fell back on Preact'srender.This PR also cleans up some tests that were never run. We can write them properly in a separate PR.