Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use user-provided panelLayout class #627

Closed
wants to merge 1 commit into from

Conversation

ethanresnick
Copy link
Contributor

I was trying to pass in a custom panelLayout class, as seems to be a documented feature, but it didn't appear to be getting applied anywhere. I think this fixes the issue.

Previously, this class was accepted, but didn't seem to be used anywhere...
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4d9f915:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-voice-search Configuration
@algolia/autocomplete-example-vue Configuration

Haroenv added a commit that referenced this pull request Jul 16, 2021
@Haroenv
Copy link
Contributor

Haroenv commented Jul 16, 2021

Thanks for your PR! I modified the code slightly to match what's done in the rest of the code base in #628, as you can't suggest changes to files that aren't changed yet

I'll make sure to mark the commit as co-authored-by :)

Haroenv added a commit that referenced this pull request Jul 16, 2021
Thanks @ethanresnick for pointing this out!

closes #627

co-authored-by: ethanresnick <ethanresnick@users.noreply.github.com>
@francoischalifour
Copy link
Member

Thank you @ethanresnick!

@Haroenv Haroenv closed this in #628 Jul 16, 2021
Haroenv added a commit that referenced this pull request Jul 16, 2021
Thanks @ethanresnick for pointing this out!

closes #627

co-authored-by: ethanresnick <ethanresnick@users.noreply.github.com>

Co-authored-by: ethanresnick <ethanresnick@users.noreply.github.com>
@ethanresnick
Copy link
Contributor Author

@Haroenv Very much appreciate the fast action here. Thanks!

@francoischalifour
Copy link
Member

Fix released in 1.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants